Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not resolve "deepmerge" #2

Closed
varunsavaliya opened this issue Jun 26, 2024 · 5 comments
Closed

Could not resolve "deepmerge" #2

varunsavaliya opened this issue Jun 26, 2024 · 5 comments

Comments

@varunsavaliya
Copy link

I am facing one issue in this package while staring my project using npm start.
`
Could not resolve "deepmerge"

node_modules/ngx-lightweight-charts/fesm2022/ngx-lightweight-charts.mjs:7:22:
  7 │ import deepmerge from 'deepmerge';
   You can mark the path "deepmerge" as external to exclude it from the bundle, which will remove this error and leave the unresolved path in the bundle.
   D:\Projects\trading-view-frontend-new\node_modules\vite\node_modules\esbuild\lib\main.js:1651

`

Waiting for any help.

@jamesbrobb
Copy link
Owner

I'm presuming you're using the default npm start that's set up to run ng serve in your package.json 'scripts'?

deepmerge is a dependency of this library (it's listed in the peerDependencies of its package.json) and should have been installed when running npm install - so should already be in your node_modules.

I'm not sure why that wouldn't be the case, unless possibly you had an error when running npm install?

@jamesbrobb
Copy link
Owner

Not sure if this might be the reason?

npm/cli#4934

@varunsavaliya
Copy link
Author

varunsavaliya commented Jun 27, 2024

Yes, this might be the issue. After installing deepmerge it's solved.
but it should be auto-installed because it is a peer dependency of the package.

@varunsavaliya
Copy link
Author

can you make it compatible with the angular 18 version? Currently, it supports 17 only.

@jamesbrobb
Copy link
Owner

I'm hoping to have a look at creating an v18 version this weekend, i'll let you know once it's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants