Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyLit Knee Point #14

Open
dcharatan opened this issue Apr 10, 2020 · 0 comments
Open

StyLit Knee Point #14

dcharatan opened this issue Apr 10, 2020 · 0 comments

Comments

@dcharatan
Copy link

dcharatan commented Apr 10, 2020

Hi,

Figure 6 of the StyLit paper shows a knee point finding step on the sorted errors of a reverse NNF. It looks like this implementation only ever uses regular NNFs (i.e. target-sized 2D arrays of indices in the source). Am I misunderstanding the implementation here? It seems like this implementation uses algorithm 1 from the StyLit paper, but never does the step in the paragraph that starts with "To complete the algorithm." I would appreciate any insights, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant