Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blogViewModel and openSourceViewModel VS ViewModelProviderFactory #54

Closed
ghost opened this issue Mar 10, 2019 · 2 comments
Closed

blogViewModel and openSourceViewModel VS ViewModelProviderFactory #54

ghost opened this issue Mar 10, 2019 · 2 comments

Comments

@ghost
Copy link

ghost commented Mar 10, 2019

hi i checked both previous and new code and i have a question. as i see, you move all viewmodels to ViewModelProviderFactory and remove them from modules. Although you mention new OpenSourceViewModel(dataManager,schedulerProvider); and new BlogViewModel(dataManager,schedulerProvider); in ViewModelProviderFactory, you also provide them in OpenSourceFragmentModule and BlogFragmentModule. why did you do this ?
thanks
@jyotid jyotid mentioned this issue Mar 11, 2019
Merged
@jyotid
Copy link
Collaborator

jyotid commented Mar 11, 2019

hey,
Thanks for pointing it out.
This looks like a mistake and we have rectified it and it will be available soon in the master branch.
Reason being , now all the VM creation is delegated to VMFactory and hence there should not be any VM creation from any of the modules.

@ghost
Copy link
Author

ghost commented Mar 26, 2019

Thanks for answering me. you can close this issue

@jyotid jyotid closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jyotid