-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New plot type: ptable_scatter
#119
Comments
I would be working on this. Thanks @janosh! |
Thanks, that would be much appreciated! It can be very close in implementation to the existing ptable_hists |
I'm thinking a dedicated data type for periodic table might be justified. I'm currently unaware of any existing package (closest is periodictable but doesn't seem to be designed for parsing custom datasheet). It would be very similar to a Python dictionary, but with the keys predefined as elements (The atomic numbers should be used internally and auxiliarily for ordering) and missing values imputated. Having this, we would be able to unify handling and parsing of multiple periodic table based plots, data for What do you think? |
not sure we need a data type to represent for the use case you outline of having additional dimensions for color or marker size, a |
Thanks for sharing your thoughts @janosh. It make sense, as |
closed in #122 |
Add
ptable_scatter
equivalent toptable_hists
. Function signature can be largely identical except each element data must specify both x and y data. Could potentially have a single function that toggles betweenhist
andscatter
depending on presence of y data.pymatviz/pymatviz/ptable.py
Lines 745 to 795 in 882a6ca
The text was updated successfully, but these errors were encountered: