Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptable_scatters allow 3rd data dimension for colormap #141

Closed
DanielYang59 opened this issue May 10, 2024 · 0 comments · Fixed by #155
Closed

ptable_scatters allow 3rd data dimension for colormap #141

DanielYang59 opened this issue May 10, 2024 · 0 comments · Fixed by #155
Assignees
Labels
enhancement New feature or request matplotlib Concerning matplotlib-powered functions ptable Periodic table

Comments

@DanielYang59
Copy link
Collaborator

DanielYang59 commented May 10, 2024

ptable_scatters allow 3rd data dimension for colormap

Remind myself in case it gets lost.

Need to re-enable:

@pytest.mark.skip(reason="3rd color dimension not implemented yet") # TODO:
def test_ptable_scatters_colored() -> None:
"""Test ptable_scatters with 3rd color dimension."""
fig = ptable_scatters(
data={
"Fe": [[1, 2, 3], [4, 5, 6], [7, 8, 9]],
"O": [[10, 11], [12, 13], [14, 15]],
},
# colormap="coolwarm",
# cbar_title="Test ptable_scatters",
)
assert isinstance(fig, plt.Figure)
assert len(fig.axes) == 180

Also need to fix plotting of examples/diatomics/homo-nuclear-mace-medium.svg.

TODO: allow colormap with 3rd data dimension

@janosh janosh changed the title [Enhancement] ptable_scatters allow 3rd data dimension for colormap ptable_scatters allow 3rd data dimension for colormap May 10, 2024
@janosh janosh added enhancement New feature or request matplotlib Concerning matplotlib-powered functions ptable Periodic table labels May 10, 2024
@DanielYang59 DanielYang59 self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request matplotlib Concerning matplotlib-powered functions ptable Periodic table
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants