Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image comparison tests for all matplotlib plots #22

Closed
janosh opened this issue Feb 28, 2022 · 1 comment
Closed

Add image comparison tests for all matplotlib plots #22

janosh opened this issue Feb 28, 2022 · 1 comment
Assignees
@janosh
Labels
matplotlib Concerning matplotlib-powered functions testing Test all the things

Comments

@janosh
Copy link
Owner

janosh commented Feb 28, 2022

As in #20 (tests/test_struct_vis.py), use matplotlib.testing.compare.compare_images() to test all functions that generate matplotlib figures.
@janosh janosh added the testing Test all the things label Feb 28, 2022
@janosh janosh self-assigned this Feb 28, 2022
@janosh janosh added the matplotlib Concerning matplotlib-powered functions label Mar 15, 2022
@janosh
Copy link
Owner Author

janosh commented Mar 19, 2022 •
edited
Loading

Maybe actually not worth the trouble. Makes tests very brittle to the point where the image diff tolerance needs to be so high that it seems less valuable. See 2882acf where diff RMS was bumped from 0.8 to 100.

@janosh janosh closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2022
@janosh janosh mentioned this issue Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janosh janosh

Labels
matplotlib Concerning matplotlib-powered functions testing Test all the things
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janosh