Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent accidental trashing on 'x' #1101

Closed
engrka opened this issue Jul 9, 2021 · 8 comments
Closed

Prevent accidental trashing on 'x' #1101

engrka opened this issue Jul 9, 2021 · 8 comments

Comments

@engrka
Copy link

engrka commented Jul 9, 2021

I'm always a bit worried accidentally hitting x and moving a file to wastebasket while not noticing it. Switching to deletion without moving to wastebasket, which till trigger a prompt, isn't an option either.
Should I just change the hotkeys to something more specific than simply hitting "x" ? Are there any suggestions?
Thanks for the great software.

@jarun
Copy link
Owner

jarun commented Jul 9, 2021

We can add a prompt but many users don't like additional steps in straight workflows.
However, I can understand that pressing x can go unnoticed. I am adding a prompt to confirm trashing.

@jarun jarun closed this as completed in 5f5ee10 Jul 9, 2021
@jarun
Copy link
Owner

jarun commented Jul 9, 2021

Please test and confirm the fix works as expected.

@Kabouik
Copy link
Collaborator

Kabouik commented Jul 9, 2021

This is something I asked a couple years ago and @jarun indeed replied that many users wouldn't like that, so I ended up just patching nnn.c and nnn.h every time I git clone to remove the corresponding code and update the help screen so that just ^x is mentioned.

[Edit] Happy to see a prompt for x though. Is it for ^x too?

@jarun jarun mentioned this issue Jul 9, 2021
10 tasks
@jarun jarun changed the title best way to prevent accidental "move to waste" by hitting x Prevent accidental "move to waste" by hitting x Jul 9, 2021
@jarun jarun changed the title Prevent accidental "move to waste" by hitting x Prevent accidental trashing on 'x' Jul 9, 2021
@jarun
Copy link
Owner

jarun commented Jul 9, 2021

Yes, this is for both x and ^x.

@engrka
Copy link
Author

engrka commented Jul 9, 2021

Works as expected in first basic tests. I'll do some more testing in the next days and report if there are any issues. Thank you.

@oscarpax
Copy link

How about x with prompt and ^x with no prompt? I'd prefer that..

@jarun
Copy link
Owner

jarun commented Jul 21, 2021

Sorry, it's a genuine guard and safe. No plans to change anything in the workflow.

@oscarpax
Copy link

That's fine, thank you for very useful software!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants