Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nsxiv support to nuke, preview-tabbed and imgview #1230

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

N-R-K
Copy link
Collaborator

@N-R-K N-R-K commented Nov 10, 2021

nuke and preview-tabbed works as expected. I would assume imgview
should work as expected as well since nsxiv (at the moment at least)
is a drop-in replacement for sxiv, but I haven't tested it.

Closes: #1229

`nuke` and `preview-tabbed` works as expected. I would assume `imgview`
should work as expected as well since `nsxiv` (at the moment at least)
is a drop-in replacement for sxiv, but I haven't tested it.

Closes: jarun#1229
@N-R-K N-R-K requested a review from luukvbaal November 10, 2021 16:49
Copy link
Collaborator

@luukvbaal luukvbaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this but if it is indeed a drop-in replacement it looks good to me.

@tonijarjour
Copy link
Contributor

I tested tabbed and imgview and they both work. Thank you.

@jarun jarun merged commit fec0479 into jarun:master Nov 11, 2021
@jarun
Copy link
Owner

jarun commented Nov 11, 2021

Thank you!

@N-R-K N-R-K deleted the nsxiv_support branch November 11, 2021 01:17
@jarun jarun mentioned this pull request Nov 17, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sxiv is dead, maybe add support for nsxiv?
4 participants