Add Elixir icon #1437
Merged
Add Elixir icon #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please refer to PR #1419. @N-R-K @luukvbaal please take a call. |
N-R-K
requested changes
Jul 25, 2022
src/icons.h
Outdated
| @@ -303,6 +317,7 @@ static const struct icon_pair icons_ext[] = { | |||
| {"lua", ICON_EXT_LUA, COLOR_LUA}, | |||
| {"lzh", ICON_ARCHIVE, COLOR_ARCHIVE}, | |||
| {"lzma", ICON_ARCHIVE, COLOR_ARCHIVE}, | |||
| {"lock", ICON_LOCKFILE, 0}, | |||
There was a problem hiding this comment.
What's the "lock" extension used for and how common is it? Quick internet search seems to suggest it's something related to minecraft?
There was a problem hiding this comment.
No some package managers/build systems maintain a 'lock' file to freeze the dependencies to specific version so that when the app is built builder knows exact versions to pick. Elixir's mix is one such tool. In elixir, mix.exs stores the dependencies and mix.lock has exact versions and other details.
N-R-K
requested changes
Jul 25, 2022
|
@N-R-K please confirm when we are good to merge. |
|
@jarun Pushed the changes. Should be good to merge. (Probably should "squash-merge" it though). |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added Erlang and Elixir icons with colors for different related file extensions. Let me know if I have done anything wrong or unacceptable.