Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust icons #1502

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Add Rust icons #1502

merged 2 commits into from
Oct 5, 2022

Conversation

gaoDean
Copy link
Contributor

@gaoDean gaoDean commented Oct 5, 2022

Hello, I don't know if I'm just missing something, but I saw that there was rust support in the icons-in-terminal.h but it wasn't used, so I added this and the nerd-font equivalent to the icons.h.

@jarun
Copy link
Owner

jarun commented Oct 5, 2022

@N-R-K or @luukvbaal please review. If all icons supported are covered feel free to merge.

Copy link
Collaborator

@N-R-K N-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@N-R-K N-R-K merged commit 38b7282 into jarun:master Oct 5, 2022
@N-R-K
Copy link
Collaborator

N-R-K commented Oct 5, 2022

Is it just my setup or is the rust icon a bit too small to be visually distinguishable? But then again, the c++ icon is pretty hard to distinguish from the C icon as well, so 🤷

image

@gaoDean does the icon appear well on your setup? The above screenshot is with O_NERD=1.

@gaoDean
Copy link
Contributor Author

gaoDean commented Oct 5, 2022

@N-R-K yeah it is a bit small, but that's a nerdfont problem.

@jarun
Copy link
Owner

jarun commented Oct 7, 2022

@N-R-K can you please check the build failure?

@jarun
Copy link
Owner

jarun commented Oct 7, 2022

CI...

@N-R-K
Copy link
Collaborator

N-R-K commented Oct 7, 2022

@N-R-K can you please check the build failure?

Sure, but I'm getting a 403 error when I try to view the CI logs...

@KlzXS
Copy link
Collaborator

KlzXS commented Oct 7, 2022

I can view it just fine. On master this is what I get:

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

Other than that it's complaining about browse() in other commits, which is not unusual.

@jarun
Copy link
Owner

jarun commented Oct 7, 2022

I'll need some time to get bk to my laptop.

@jarun jarun mentioned this pull request Oct 22, 2022
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants