Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icons-hash: replace assert with handmade version #1633

Merged
merged 1 commit into from
Apr 23, 2023
Merged

icons-hash: replace assert with handmade version #1633

merged 1 commit into from
Apr 23, 2023

Conversation

N-R-K
Copy link
Collaborator

@N-R-K N-R-K commented Apr 23, 2023

since 2fc9d51, the hash-table generator inherits environmental CFLAGS and so we shouldn't disallow setting -DNDEBUG.

fixes: #1632

@N-R-K
icons-hash: replace assert with handmade version
20725b0 
since 2fc9d51, the hash-table generator inherits environmental
CFLAGS and so we shouldn't disallow setting -DNDEBUG.

fixes: jarun#1632
@jarun jarun merged commit 8fd1822 into jarun:master Apr 23, 2023
@jarun
Copy link
Owner

jarun commented Apr 23, 2023

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
@N-R-K N-R-K deleted the assert_fix branch June 10, 2023 05:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please don't force enable assertions.
2 participants
@N-R-K @jarun