Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't find partials in the same directory, no recompilation after change of a partial. #95

Closed
ZeroMax-dev opened this issue Feb 19, 2015 · 10 comments

Comments

@ZeroMax-dev
Copy link

Using a fresh Brackets 1.1 and brackets-sass 1.0.4-83 on Win8.1 (64-bit) if i import a partial that is in the same directory as the importing file with @import "partial"; I get an error File to import not found or unreadable. My file structure is as follows:

/
-> css/main.css
-> css/main.css.map
-> img/etc.
-> scss/_partial.scss
-> scss/main.scss
index.html
.brackets.json

If I add the full absolute path to the scss-directory ("X:/Documents/project/scss/") in the includePath-attribute in the .brackets.json the partials are being found. But even then, if I change the contents of a partial the change is not detected and the main.scss is not recompiled. It is only recompiled if i make a change in the main.scss.

@ofhouse
Copy link

ofhouse commented Feb 22, 2015

I have the same issue.
Found out, that the extension don't recognizes partials correctly instead it handles them as normal InputFiles.
Edit: Ok, partials are only recognized as partials if they have a leading '_' because of Regex.

Maybe a result of this issue?

@CydGoblin
Copy link

I have the same problem even if they are in different folders but they do compile on save despite the error
image

@ofhouse
Copy link

ofhouse commented Feb 23, 2015

Have you set includePaths in your .brackets.json?

@CydGoblin
Copy link

This is my file

{
    "sass.enabled": true,
    "path": {
        "scss/main.scss": {
            "sass.enabled": true,
            "sass.options": {
                "outputDir": "../stylesheets",
                "includePaths": [],
                "imagePath": null,
                "sourceComments": false,
                "outputStyle": "nested"
            }
        }
    }
}

But this is happening with new projects and project i've been working just fine, don't know what happened since i did not modified them and it is just in windows, on mac it's fine

@nicolo-ribaudo
Copy link
Contributor

I think it's because your projects are on a drive other than c:/

Can you test if in this branch partials are found?

@CydGoblin
Copy link

@nicolo-ribaudo excuse my ignorance, but how can i test the brach? what file(s) should i download

@nicolo-ribaudo
Copy link
Contributor

nicolo-ribaudo commented Feb 27, 2015 via email

@CydGoblin
Copy link

Is this the url https://github.com/nicolo-ribaudo/brackets-sass/archive/issue-95.zip? because i get this

image
image

@ofhouse
Copy link

ofhouse commented Feb 28, 2015

Yeah, it's the right package but the install fails because Github is not able to include submodules (thirdparty/source-map/) in the zip archive.

Better use git clone instead if you are familiar with git.

@jasonsanjose
Copy link
Owner

Closing as duplicate of #91.

@ZeroMax-dev @Turqueso See comment here #91 (comment) to try the latest dev build with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants