fix: enable default_setup during reload #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `mason-null-ls.automatic_setup` function has no return value and so can't be
memoized effectively -- it exists strictly for its side-effects. This change is
necessary to make mason-null-ls cooperate during a reload of configuration.
Previously the below code would work on initial executtion but noop
subsequently, resulting in no null-ls diagnostics. Now it behaves as expected.
```lua
require("null-ls.config").reset()
require("null-ls").setup({ on_attach = M.on_attach_null_ls })
require("mason-null-ls").setup({
handlers = { require("mason-null-ls").default_setup },
})
```
Without this change I have to work around, using an un-memoized copy-paste of
the automatic-setup function as my handler.
ghost
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mason-null-ls.automatic_setupfunction has no return value and so can't be memoized effectively -- it exists strictly for its side-effects. This change is necessary to make mason-null-ls cooperate during a reload of configuration.Previously the below code would work on initial executtion but noop subsequently, resulting in no null-ls diagnostics. Now it behaves as expected.
Without this change I have to work around, using an un-memoized copy-paste of the automatic-setup function as my handler.