Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Lazily require adapter mappings #77

Merged
merged 8 commits into from
Apr 22, 2023
Merged

Conversation

Natr1x
Copy link
Contributor

@Natr1x Natr1x commented Apr 21, 2023

Implementation of the performance improvement in #70 that should not cause #73 #74 which required the previous pull request #75 to need to be reversed.

Why?

The change in #70 returned errors whenever trying to get an adapter which was not mapped instead of just returning nil.

What

The fix is simply to return nil for unmapped adapters. (Something which I thought of but then apparently did not do for some reason..)

Testing Done (and which can be done)

I have tested with installing and running java-debug-adapter #73 which caused an error because it is not mapped in mason-nvim-dap.mappings.adapters and elixir-ls #74 which will try to get an adapter for 'elixir' when the handler is set up, which will is also not a mapping that exists.

I am not regularly using these these adapters however so I would probably be good if someone who has encountered the problems in #73 and #74 tests this before any merging is done.

@jay-babu jay-babu changed the title perf: Fixed version of 'Lazily require adapter mappings' perf: Lazily require adapter mappings Apr 21, 2023
@jay-babu
Copy link
Owner

Thanks for all the help! merging attempt 2

@jay-babu jay-babu merged commit 7168745 into jay-babu:main Apr 22, 2023
jay-babu added a commit that referenced this pull request Apr 22, 2023
Co-authored-by: Jay Patel <36803168+jay-babu@users.noreply.github.com>
@y1rn
Copy link

y1rn commented Apr 23, 2023

lua/mason-nvim-dap/mappings/adapters/init.lua

local adapter, ok = pcall(require, 'mason-nvim-dap.mappings.adapters.' .. key)

should be

local ok, adapter = pcall(require, 'mason-nvim-dap.mappings.adapters.' .. key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mappings/adapters.lua can be very slow due to vim.fn.exepath
3 participants