Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.16e #362

Merged
merged 26 commits into from
Jun 23, 2023
Merged

V0.16e #362

merged 26 commits into from
Jun 23, 2023

Conversation

jblance
Copy link
Owner

@jblance jblance commented Jun 6, 2023

No description provided.


def __init__(self, config):
@classmethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@rossandrews rossandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for disappearing for a bit, went on a vacation and took some time to get back into my routine.

Lot of great changes in here, looking forward to working with them.

@@ -1,6 +1,7 @@
from pydantic import BaseModel


# TODO: update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you like updated on the DTOs?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its just a reminder that they need to be updated to cater for the changes that are being made

makefile Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just reading up docker-compose standalone vs docker compose plugin. Looks like you are ahead of me.

@jblance jblance merged commit b0d2948 into master Jun 23, 2023
@jblance jblance deleted the v0.16e branch June 23, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants