Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading parent in pom.xml from 1.20.1 to 1.23 causes checkstyle errors #94

Open
PeteKeller opened this issue Feb 16, 2017 · 3 comments

Comments

@PeteKeller
Copy link
Contributor

PeteKeller commented Feb 16, 2017

[INFO] Checkstyle: jcabi-log\src\it\it-decoloring\src\main\java\com\jcabi\log\MulticolorLayoutIntegration.java[32]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[153]: Indentation (20) must be same or less than previous line (12), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\it\it-decoloring\src\test\java\com\jcabi\log\MulticolorLayoutIntegrationTest.java[188]: Indentation (20) must be same or less than previous line (12), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ColorfullyFormatted.java[55]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ColorfullyFormatted.java[64]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\Colors.java[92]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ConversionPattern.java[65]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ConversionPattern.java[96]: This method must be static, because it does not refer to "this" (NonStaticMethodCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ConversionPattern.java[98]: Indentation (17) must be same or less than previous line (8), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\DecorsManager.java[59]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\DomDecor.java[89]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\DullyFormatted.java[49]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\DullyFormatted.java[58]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ExceptionDecor.java[79]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ListDecor.java[78]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\Logger.java[402]: At-clauses have to appear in the order '[@author, @version, @param, @return, @throws, @exception, @see, @since, @serial, @serialField, @serialData, @deprecated, @todo, @checkstyle]'. (AtclauseOrderCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MsDecor.java[79]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MsDecor.java[111]: Variable 'number' should be declared final. (FinalLocalVariableCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MsDecor.java[112]: Variable 'title' should be declared final. (FinalLocalVariableCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MulticolorLayout.java[115]: Indentation (16) must be same or less than previous line (8), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MulticolorLayout.java[136]: Comments in method body are prohibited (MethodBodyCommentsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MulticolorLayout.java[178]: This method must be static, because it does not refer to "this" (NonStaticMethodCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MulticolorLayout.java[200]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\MulticolorLayout.java[214]: This method must be static, because it does not refer to "this" (NonStaticMethodCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\NanoDecor.java[80]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\NanoDecor.java[111]: Variable 'number' should be declared final. (FinalLocalVariableCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ParseableInformation.java[53]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ParseableInformation.java[64]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ParseableLevelInformation.java[56]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\ParseableLevelInformation.java[69]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\PreFormatter.java[82]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\SizeDecor.java[61]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\SizeDecor.java[83]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\SizeDecor.java[91]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\Supplier.java[40]: At-clauses have to appear in the order '[@author, @version, @param, @return, @throws, @exception, @see, @since, @serial, @serialField, @serialData, @deprecated, @todo, @checkstyle]'. (AtclauseOrderCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\SupplierLogger.java[102]: This method must be static, because it does not refer to "this" (NonStaticMethodCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\TextDecor.java[76]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\TypeDecor.java[65]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\TypeDecor.java[73]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseCallable.java[61]: Type Javadoc comment is missing an @param <T> tag. (JavadocTypeCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseCallable.java[174]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseRunnable.java[136]: Comment has incorrect indentation level 20, expected is 24, indentation should be the same level as line 135. (CommentsIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseRunnable.java[193]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseRunnable.java[198]: Comment has incorrect indentation level 8, expected is 12, indentation should be the same level as line 197. (CommentsIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\main\java\com\jcabi\log\VerboseRunnable.java[205]: Comment has incorrect indentation level 8, expected is 12, indentation should be the same level as line 204. (CommentsIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\AbstractDecorTest.java[41]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\DecorMocker.java[61]: Overridden methods should not have Javadoc (NoJavadocForOverriddenMethodsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\DecorsManagerTest.java[36]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\DomDecorTest.java[41]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\ExceptionDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\ListDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\LoggerTest.java[41]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\MsDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\MulticolorLayoutTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\NanoDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\ObjectDecorTest.java[39]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\ObjectDecorTest.java[112]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\PreFormatterTest.java[36]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SecretDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SizeDecorTest.java[40]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[53]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[54]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[79]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[80]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[107]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[108]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[133]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[134]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[161]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[162]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[187]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[188]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[215]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[216]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[241]: Name 'loggerName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\SupplierLoggerTest.java[242]: Name 'appenderName' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\TextDecorTest.java[44]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\TypeDecorTest.java[39]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[60]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[311]: Name 'verboseProcess' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[370]: Name 'inputStream' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[371]: Name 'errorStream' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[386]: Name 'verboseProcess' must match pattern '^(id|[a-z]{3,12})$'. (LocalFinalVariableNameCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[428]: Indentation (20) must be same or less than previous line (12), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[460]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[510]: Redundant 'public' modifier. (RedundantModifierCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseProcessTest.java[520]: Indentation (20) must be same or less than previous line (12), or bigger by exactly 4 (CascadeIndentationCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseRunnableTest.java[42]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseRunnableTest.java[162]: Use diamond operator (DiamondOperatorCheck)
[INFO] Checkstyle: jcabi-log\src\test\java\com\jcabi\log\VerboseThreadsTest.java[38]: Missing '@since' tag in class/interface comment (JavadocTagsCheck)
[INFO] Read our quality policy: http://www.qulice.com/quality.html
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:28 min
[INFO] Finished at: 2017-02-16T07:50:42-05:00
[INFO] Final Memory: 49M/571M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.qulice:qulice-maven-plugin:0.17.1:check (jcabi-check) on project jcabi-log: Failure: There are 91 violations -> [Help 1]
[ERROR]
@0crat
Copy link

0crat commented Feb 16, 2017

@yegor256 please, pay attention to this issue

@PeteKeller
Copy link
Contributor Author

@yegor256 I will start cleaning these up soon.

@yegor256
Copy link
Member

@PeteKeller thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants