From 654052d5a5ec6e4f37b72ab85ea8923c97e34725 Mon Sep 17 00:00:00 2001 From: Olivier Dony Date: Fri, 29 Jan 2021 18:43:17 +0000 Subject: [PATCH] [FIX] registry: do not signal a phantom cache clear on load During loading, the registry clears all `ormcache` data multiple times, in order to ensure consistency with the newly loaded module data. Since 083c70bbb63f27839b2c9a4b549e216947bc4dd1, this was done by calling `self.clear_caches()`, with the side-effect of signalling to all other worker processes that the cache *needs* to be invalidated, which is actually untrue. If the other workers have any reason to reload their own registries, they will also clear their own cache in the process - there is no need to forcefully invalidate it globally. One could think that combining the pre-fork mode with the `-d ` parameter would mitigate this issue, by making all workers inherit from a fully loaded registry, In reality it doesn't work, because they also inherit from the `cache_invalidated=True` flag, that was never cleared in the master process. So despite having a fully loaded registry, the newly forked workers will signal a cache invalidation upon serving their first request. Further, in a multi-tenant setup with large numbers of databases, registries may be recycled and loaded much more frequently than new workers are starting, due to the limited registry LRU, amplifying this effect a bit. ~~ This patch directly clears the cache LRU without going through `clear_cache()`, avoiding setting the `cache_invalidated` flag of the registry, and thus not signalling to other workers. This is similar to what was being done before 083c70bbb63f27839b2c9a4b549e216947bc4dd1, where the LRU was dropped like all other lazy properties. X-original-commit: 87aef4e3a36d92462454f51960abf7215c5ab7f1 --- odoo/modules/registry.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/odoo/modules/registry.py b/odoo/modules/registry.py index e03d9ecf44702..3397ab407ed11 100644 --- a/odoo/modules/registry.py +++ b/odoo/modules/registry.py @@ -219,7 +219,9 @@ def load(self, cr, module): """ from .. import models - self.clear_caches() + # clear cache to ensure consistency, but do not signal it + self.__cache.clear() + lazy_property.reset_all(self) # Instantiate registered classes (via the MetaModel automatic discovery @@ -244,7 +246,9 @@ def setup_models(self, cr): for model in env.values(): model._unregister_hook() - self.clear_caches() + # clear cache to ensure consistency, but do not signal it + self.__cache.clear() + lazy_property.reset_all(self) self.registry_invalidated = True