Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to add link to @mention manually #2

Closed
muan opened this issue Jan 23, 2014 · 4 comments
Closed

Being able to add link to @mention manually #2

muan opened this issue Jan 23, 2014 · 4 comments
Labels

Comments

@muan
Copy link

muan commented Jan 23, 2014

Sometimes people don't have a GitHub profile, and I'd like to have @benbalter instead of @benbalter.

Looks like on .com it works as expected. However with jekyll-mentions I get:
<a href=‘https://github.com/benbalter’ class=‘user-mention’>@benbalter

@parkr
Copy link
Member

parkr commented Jan 23, 2014

Hey muan!

Does .com use HTML::Pipeline::MentionFilter? It could be that the generator is running during Jekyll's render process at the wrong time relative to what the MentionFilter expects (i.e. it is HTML when MentionFilter gets to it, rather than Markdown).

@benbalter
Copy link
Contributor

Yep. Due to limitations in Jekyll, for now at least, we have to run the filter on the raw markdown, not the generated HTML, as we'd like. In the mean time, you could move the @ outside the link, or encode it as &#64;.

gjtorikian/html-pipeline#100 and #1 for background.

@muan
Copy link
Author

muan commented Jan 24, 2014

Thanks for the work around! ✨

@parkr
Copy link
Member

parkr commented Jun 29, 2016

@muan This should be fixed now that we're using HTML Pipeline properly ✨ ❤️

@parkr parkr closed this as completed Jun 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants