-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expressionBuilder): add ability to reference an attribute #143
Conversation
Can you add this to the README too? |
@craPkit this is a nice feature would be great to see it merged 😄 I added support for nested attribute conditions and filters in #288, #294 and #297 so you'll need to merge main and adapt this PR accordingly but shouldn't be too much work and the collective changes will complement each other nicely 🙏🏼 |
Main is merged now. I haven't implemented nested attributes in my AttrRefs though, since, being ignorant of your feature, I wasn't sure which cases need to be covered. |
Hey @craPkit , Sorry for the late reply to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good,
left one small nit comment.
Let's also add a validation and a test that begins_with
is not used with an AttrRef
because it's currently generating an invalid expression.
Once that's addressed, this PR will be ready to merge 😎
Implements #142
Supports referenced attributes on FilterExpressions' fields 'eq' | 'ne' | 'lt' | 'lte' | 'gt' | 'gte'.
How To:
Positive and negative tests included.