Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity): add format function property #332

Merged
merged 8 commits into from
Nov 3, 2022

Conversation

GeertWille
Copy link
Contributor

We needed a way to be able to format a value coming from DynamoDB before parsing it. That's why we added a format field option.

This is a new updated PR with the changes asked in #90 .

@GeertWille GeertWille mentioned this pull request Sep 20, 2022
@naorpeled
Copy link
Collaborator

Hey @GeertWille,
will review this PR asap.

Thanks for creating it, you're awesome 😎 🙏

Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great 🔥

Let's add a test that mocks the DDB returned value and make sure that format is acting as we're expecting.

After that test is added and my comments are addressed, the PR will be ready to merge imo.

src/__tests__/entity-creation.unit.test.ts Outdated Show resolved Hide resolved
src/__tests__/entity-creation.unit.test.ts Outdated Show resolved Hide resolved
src/__tests__/entity-creation.unit.test.ts Outdated Show resolved Hide resolved
src/lib/formatItem.ts Outdated Show resolved Hide resolved
docs/docs/entity/index.md Outdated Show resolved Hide resolved
Geert Wille and others added 6 commits October 12, 2022 23:12
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
@GeertWille
Copy link
Contributor Author

Overall looks great 🔥

Let's add a test that mocks the DDB returned value and make sure that format is acting as we're expecting.

After that test is added and my comments are addressed, the PR will be ready to merge imo.

Added a test for the format function

Copy link
Collaborator

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

Great job!

@naorpeled naorpeled changed the title Add format function feat(entity): add format function property Nov 3, 2022
@naorpeled naorpeled merged commit e16455d into dynamodb-toolbox:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants