-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(entity): add format function property #332
Conversation
Hey @GeertWille, Thanks for creating it, you're awesome 😎 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great 🔥
Let's add a test that mocks the DDB returned value and make sure that format
is acting as we're expecting.
After that test is added and my comments are addressed, the PR will be ready to merge imo.
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Co-authored-by: Naor Peled <thehecticbyte@gmail.com>
Added a test for the format function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😎
Great job!
We needed a way to be able to format a value coming from DynamoDB before parsing it. That's why we added a format field option.
This is a new updated PR with the changes asked in #90 .