Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findRelatedTests + coverage doesn't match findRelatedTests + collectCoverageFrom #10083

Closed
7rulnik opened this issue May 25, 2020 · 4 comments
Closed

Comments

@7rulnik
Copy link

7rulnik commented May 25, 2020

🐛 Bug Report

As it said in docs and in this comment findRelatedTests + coverage should be equal to findRelatedTests and collectCoverageFrom. But it's not because we concat collectCoverageFrom from config with files from findRelatedTests.

To Reproduce

Compare these two commands:

yarn jest --findRelatedTests packages/jest-snapshot/src/dedentLines.ts --coverage
yarn jest --findRelatedTests packages/jest-snapshot/src/dedentLines.ts --coverage --collectCoverageFrom packages/jest-snapshot/src/dedentLines.ts

Expected behavior

I believe that result of these commands should be equal. Maybe we should override positive paths from collectCoverageFrom but leave negative (starts with !)?

envinfo


  System:
    OS: macOS 10.15.5
    CPU: (8) x64 Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz
  Binaries:
    Node: 14.0.0 - ~/.fnm/current/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.14.4 - ~/.fnm/current/bin/npm
@7rulnik
Copy link
Author

7rulnik commented May 30, 2020

Seems related to #7427

@github-actions
Copy link

This issue is stale because it has been open for 1 year with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Feb 17, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity. Please open a new issue if the issue is still relevant, linking to this one.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants