Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested manual mock fails with folders on Windows #4014

Closed
tw0517tw opened this issue Jul 12, 2017 · 2 comments
Closed

Nested manual mock fails with folders on Windows #4014

tw0517tw opened this issue Jul 12, 2017 · 2 comments

Comments

@tw0517tw
Copy link

Do you want to request a feature or report a bug?

BUG
related to #2483 ?

What is the current behavior?

When creating nested mocks with module/folder/file it will fail on Windows due to separation character.
For example, creating file

/__mocks__/lodash/fp/add.js
                 ^^^^folder

to mock lodash/fp/add will fail on Windows.

But using file

/__mocks__/lodash/sum.js
               ^^^^^no folder

to mock lodash/sum would just work fine.

If the current behavior is a bug, please provide the steps to reproduce and either a repl.it demo through https://repl.it/languages/jest or a minimal repository on GitHub that we can yarn install and yarn test.

Check my reproducing repo and its CI status.

What is the expected behavior?

It should mock lodash/fp/add with /__mocks__/lodash/fp/add.js on Windows.
I've tried to modify this line in get_mock_name.js, adding .replace(/\\/g, '/') at the end and this was working. But I'm not sure if this is the best solution.

Please provide your exact Jest configuration and mention your Jest, node, yarn/npm version and operating system.

In the repo above with 2 CIs.

@thymikee
Copy link
Collaborator

Fixed in #4238

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants