Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"yarn test" in master branch fails on new installation #9015

Closed
psytechno604 opened this issue Oct 6, 2019 · 3 comments · Fixed by #9098
Closed

"yarn test" in master branch fails on new installation #9015

psytechno604 opened this issue Oct 6, 2019 · 3 comments · Fixed by #9098

Comments

@psytechno604
Copy link

psytechno604 commented Oct 6, 2019

🐛 Bug Report

I just wanted to contribute. Followed the guide, and got:

> yarn test
yarn run v1.19.0
$ yarn lint && yarn jest
$ eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md

/Users/sergey/Documents/opensource/jest/packages/jest-haste-map/src/lib/FSEventsWatcher.ts
  14:1  error  Unused eslint-disable directive (no problems were reported)

✖ 1 problem (1 error, 0 warnings)

To make sure that it is not my fault, I repeated the same with other system, and got:

> yarn test
yarn run v1.19.0
$ yarn lint && yarn jest
$ eslint . --cache --report-unused-disable-directives --ext js,jsx,ts,tsx,md

/home/plazmer/Documents/jest/packages/jest-worker/src/workers/NodeThreadsWorker.ts
  11:1  error  Unused eslint-disable directive (no problems were reported from 'import/no-unresolved')

/home/plazmer/Documents/jest/packages/jest-worker/src/workers/threadChild.ts
  9:1  error  Unused eslint-disable directive (no problems were reported from 'import/no-unresolved')

✖ 2 problems (2 errors, 0 warnings)

So, as we can see, errors occur in different files, but in both cases they are linked to eslint. Maybe need to use specific version? Again - I did not made any changes in both cases, strictly following the given scenario.

To Reproduce

Steps to reproduce the behavior:
Just follow this guide from scratch - https://github.com/facebook/jest/blob/master/CONTRIBUTING.md

(I did this on two different systems and got eslint errors in both cases)

Expected behavior

"yarn test" should work without errors.

envinfo

  1. System:
    OS: macOS 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i5-8279U CPU @ 2.40GHz
    Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.19.0 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm

  2. System:
    OS: Linux 4.15 Ubuntu 16.04.6 LTS (Xenial Xerus)
    CPU: (1) x64 Intel(R) Core(TM) i5-6300HQ CPU @ 2.30GHz
    Binaries:
    Node: 11.14.0 - /usr/bin/node
    Yarn: 1.19.0 - /usr/bin/yarn
    npm: 6.9.2 - /usr/bin/npm

@thymikee
Copy link
Collaborator

thymikee commented Oct 6, 2019

I can reproduce this error on warm and cold eslint cache:

/Users/thymikee/Projects/oss/jest/packages/jest-haste-map/src/lib/FSEventsWatcher.ts
  14:1  error  Unused eslint-disable directive (no problems were reported)

Not sure why it differs from the CI.

I'm curious though, how you manage to run yarn 1.19, when we explicitly set yarn-path to v1.17 bundled locally in .yarnrc file?

@psytechno604
Copy link
Author

I thought that yarn version was the reason, so I upgraded it. Nevertheless, with 1.17 everything is the same on both systems. Just now reverted back to 1.17 and tested again.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants