can't use this shard together with crystal-mysql

[Manu-sh]

can't using this shard with crystal-mysql, while stefanwille/crystal-redis is not affect by this issue

Resolving dependencies
Fetching https://github.com/jgaskins/redis.git
Fetching https://github.com/jgaskins/crystal-db.git
Fetching https://github.com/crystal-lang/crystal-mysql.git
Error shard name (db) has ambiguous sources: 'git: https://github.com/jgaskins/crystal-db.git' and 'git: https://github.com/crystal-lang/crystal-db.git'.

[jgaskins]

This shard currently depends on my fork of crystal-db that allows its DB::Pool class to be used as a general-purpose connection pool since it's threadsafe. stefanwille/crystal-redis uses the ysbaddaden/pool shard which is not (I found this out the hard way running an app with -Dpreview_mt). More context on that here.

I submitted the branch this shard uses as a PR to crystal-db to allow DB::Pool to be used as a general-purpose connection pool and it just got merged a few days ago, so I should be able to update this shard to use that.

[jgaskins]

It's okay, you don't need to close this, it's definitely a problem. 🙂

[z64]

@Manu-sh One way you may be able to get around this is to use shard.override.yml, available in shards v0.12:

$ shards --version
Shards 0.12.0 [218eb62] (2020-08-12)

$ cat shard.override.yml
dependencies:
  db:
    github: jgaskins/crystal-db
    branch: generic-pool

and re-run shards install.

[Manu-sh]

@z64 thankyou for this information, maybe could be useful in future

[jgaskins]

@z64 TIL! This sounds like a much cleaner stopgap than what I ended up doing. I forked will/crystal-pg to have it use my fork/branch of crystal-db. I just installed shards v0.12 and will definitely use this! Thank you!

[jgaskins]

@Manu-sh crystal-db v0.10 has been released with support for a generic connection pool. I've updated shard.yml with that version in this commit so we should be good to go here.