{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":80216790,"defaultBranch":"master","name":"sass-extract","ownerLogin":"jgranstrom","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-01-27T15:02:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3751473?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1699119415.0","currentOid":""},"activityList":{"items":[{"before":"21072b642eca5ef1fff9f1e365c5f65189e63931","after":null,"ref":"refs/heads/ci","pushedAt":"2023-11-04T17:36:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"}},{"before":"2c54b54a8736dc9c383d1f1bbdcb117490e46139","after":"21072b642eca5ef1fff9f1e365c5f65189e63931","ref":"refs/heads/master","pushedAt":"2023-11-04T17:36:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"chore: cleanup badges","shortMessageHtmlLink":"chore: cleanup badges"}},{"before":"01462e69abaa75ad00616302f1c912e911e70eb8","after":"21072b642eca5ef1fff9f1e365c5f65189e63931","ref":"refs/heads/ci","pushedAt":"2023-11-04T17:35:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"chore: cleanup badges","shortMessageHtmlLink":"chore: cleanup badges"}},{"before":"8387363740fd8ae5a35c2059876aa169df35ff7d","after":"01462e69abaa75ad00616302f1c912e911e70eb8","ref":"refs/heads/ci","pushedAt":"2023-11-04T17:28:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"chore: ci","shortMessageHtmlLink":"chore: ci"}},{"before":null,"after":"8387363740fd8ae5a35c2059876aa169df35ff7d","ref":"refs/heads/ci","pushedAt":"2023-11-04T17:27:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"chore: ci","shortMessageHtmlLink":"chore: ci"}},{"before":"b11e34d652994b34de40aa49897fbb9f2ad76b3b","after":"2c54b54a8736dc9c383d1f1bbdcb117490e46139","ref":"refs/heads/master","pushedAt":"2023-11-04T17:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"fix: map tests for incompatible node-sass syntax","shortMessageHtmlLink":"fix: map tests for incompatible node-sass syntax"}},{"before":"90e42258d6f6f14ee456bf4a1757dc68cb168699","after":"b11e34d652994b34de40aa49897fbb9f2ad76b3b","ref":"refs/heads/master","pushedAt":"2023-10-25T18:11:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"chore(release): 3.0.0","shortMessageHtmlLink":"chore(release): 3.0.0"}},{"before":"618fd93cda625a5c37dd7aa443d974bb762bad67","after":"90e42258d6f6f14ee456bf4a1757dc68cb168699","ref":"refs/heads/master","pushedAt":"2023-10-25T17:59:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"feat: Support for Dart sass (#51)\n\n* feat(importer): passing a `this` context to sass-extract's own `importer()` call\r\n\r\n* feat(importer): allow importers to return an array of resolved files\r\n\r\nnode-sass allows custom importers to resolve a given URL to multiple files paths, by returning an\r\nArray containing multiple objects: `[{file: '...'}, {file: '...'}, ...]`. This change implements\r\nthis feature also for sass-extract's extracting phase.\r\n\r\n* refactor(importer): importer functions should always call a callback instead of returning a Promise.\r\n\r\nBREAKING CHANGE: Compatibility with node-sass: importers so far had to either call a callback (when they're called in the rendering phase, by `node-sass`) or return a Promise (when they're called in the extracting phase, by `makeImporter()`). From now, importers should always call the callback function provided in the third parameter of the importer function.\r\n\r\nfix #36\r\n\r\n* fix(importer): should work also with single importer\r\n\r\nThis has been removed by accident from the original code.\r\n\r\n* --temp: adding lib files to git (until it will be available in npm)\r\n\r\n* .gitignore cosm.\r\n\r\n* chore: NPM script to install peer dependencies for development\r\n\r\n* chore: Fixing tests\r\n\r\n- `foundation-sites` changed its folder structure, and also some internal Sass values, which breaks the tests. We rather stick to the exact version from `foundation-sites`.\r\n- `node-sass` throws Error for the nested `(1, 2, 3)` key. The problem should be with node-sass itself, as it works OK with `sass`.\r\n\r\n* feat: adding `getSassImplementation()` to resolve the correct Sass implementation + Dart Sass added to `peerDependencies`\r\n\r\n* chore(deps): updating all dependencies to their latest\r\n\r\n* test: add test for the upcoming `extractOptions.implementation` option\r\n\r\nWe are iterating over each test with both the Node Sass and the Dart Sass implementations\r\n\r\n* feat: Removing inner `node-sass` imports, using the `extractOptions.implementation` option instead everywhere\r\n\r\n* fix(dart sass): Function signature in the `functions` options property must have attribute block if the function will accept parameters\r\n\r\nWhile Node Sass allowed the signature without the `($params)` block after the function name, Dart Sass is more strict on this, and throws Error if we try to call the function with parameters.\r\n\r\n* fix (dart-sass): constructor-based comparison causes error sometimes in Dart Sass\r\n\r\n- We had issues eg. in case of `SassBooleans`.\r\n- Dart Sass did not report the constructor name correctly before `1.22.5`. It instead reported a minified name, which we cannot rely on. We either need to increase the peerDependency version to `^1.22.5`, or use our `getConstructorName()`.\r\n\r\n* fix: Upgrading to `getFileId` to the new `Buffer()` API\r\n\r\n* we only promisify the render function and we only do it if renderAsync does not already exist, it is not necessarily the case for dart sass\r\n\r\n* dart sass seems to require a semicolon (or curly brackets) after mixin inclusions\r\n\r\n* dart sass does not call our importer for each file so instead, we patch fs.readFile and fs.readFileSync\r\n\r\n* dart sass seems to honor the order of @import directives unlike node sass\r\n\r\n* fix: fix extraction on windows\r\n\r\ndart sass extraction was not working on windows because paths of patched files included backslashes\r\n\r\n* chore: New build\r\n\r\n* refactor: Revert adding lib folder to git\r\n\r\n* refactor: Remove lib folder\r\n\r\n* chore: Minor code style changes\r\n\r\n---------\r\n\r\nCo-authored-by: Pierre-Dominique CHARRON <pierre@cirkwi.com>\r\nCo-authored-by: Athorcis <Athorcis@users.noreply.github.com>","shortMessageHtmlLink":"feat: Support for Dart sass (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1936135750\" data-permission-text=\"Title is private\" data-url=\"https://github.com/jgranstrom/sass-extract/issues/51\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/jgranstrom/sass-extract/pull/51/hovercard\" href=\"https://github.com/jgranstrom/sass-extract/pull/51\">#51</a>)"}},{"before":"a2b0b3d513bf88c3adb9b6b444ff81c18738b0be","after":"618fd93cda625a5c37dd7aa443d974bb762bad67","ref":"refs/heads/master","pushedAt":"2023-10-10T04:11:43.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jgranstrom","name":"John Granström","path":"/jgranstrom","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3751473?s=80&v=4"},"commit":{"message":"Merge pull request #50 from wendt88/master\n\nnode-sass peer dependency updated #47","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1657082000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/jgranstrom/sass-extract/issues/50\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/jgranstrom/sass-extract/pull/50/hovercard\" href=\"https://github.com/jgranstrom/sass-extract/pull/50\">#50</a> from wendt88/master"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADp24aggA","startCursor":null,"endCursor":null}},"title":"Activity · jgranstrom/sass-extract"}