Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Check Failure for Upcoming broom Release #111

Closed
simonpcouch opened this issue May 27, 2020 · 1 comment
Closed

CRAN Check Failure for Upcoming broom Release #111

simonpcouch opened this issue May 27, 2020 · 1 comment

Comments

@simonpcouch
Copy link

Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below, which seem to result from our planned deprecation of tidiers for mixed models.

  • checking examples ... ERROR

    Running examples in ‘merTools-Ex.R’ failed
    The error most likely occurred in:
    
    > ### Name: lmerModList
    > ### Title: Apply a multilevel model to a list of data frames
    > ### Aliases: lmerModList blmerModList glmerModList bglmerModList
    > 
    > ### ** Examples
    > 
    > sim_list <- replicate(n = 10,
    +         expr = sleepstudy[sample(row.names(sleepstudy), 180),],
    +         simplify=FALSE)
    > fml <- "Reaction ~ Days + (Days | Subject)"
    > mod <- lmerModList(fml, data = sim_list)
    > summary(mod)
    Error: No tidy method for objects of class lmerMod
    Execution halted
    
  • checking tests ...

     ERROR
    Running the tests in ‘tests/testthat-a_p.R’ failed.
    Last 13 lines of output:
      [31m──[39m [31m1. Error: print methods work for merModList (@test-merModList.R#58) [39m [31m────────[39m
      No tidy method for objects of class lmerMod
      [1mBacktrace:[22m
      [90m 1. [39mbase::summary(g1)
      [90m 2. [39mmerTools:::summary.merModList(g1)
      [90m 3. [39mmerTools::modelFixedEff(modList)
      [90m 4. [39mbase::lapply(modList, tidy, effects = "fixed", ...)
      [90m 6. [39mbroom:::tidy.default(X[[i]], ...)
      
      ══ testthat results  ═══════════════════════════════════════════════════════════
      [ OK: 285 | SKIPPED: 0 | WARNINGS: 0 | FAILED: 1 ]
      1. Error: print methods work for merModList (@test-merModList.R#58) 
      
      Error: testthat unit tests failed
      Execution halted
    

Functions and methods for tidying mixed models now live in the broom.mixed package.

We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!🙂

@jknowles
Copy link
Owner

Fixed in 0.5.2 with commit 56492d5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants