From b5d5376c5f3b395bd12ee23c8738940e13651437 Mon Sep 17 00:00:00 2001 From: Jerzy Kozera Date: Sun, 18 Nov 2018 11:51:17 +0100 Subject: [PATCH] Improve the #1036 comment a bit --- src/libs/ui/docsetsdialog.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libs/ui/docsetsdialog.cpp b/src/libs/ui/docsetsdialog.cpp index b95b6ad17..7f1172551 100644 --- a/src/libs/ui/docsetsdialog.cpp +++ b/src/libs/ui/docsetsdialog.cpp @@ -88,8 +88,9 @@ DocsetsDialog::DocsetsDialog(Core::Application *app, QWidget *parent) : QDir docsetDir(m_application->settings()->docsetPath); QString nonExistentFile(docsetDir.absoluteFilePath("just_checking.nonexistent")); // NOTE this is a workaround from https://stackoverflow.com/a/1094950 - // which attempts to check directory permissions, as opposed to "file writing" - // permissions - by passing a nonexistent file we should get more correct results: + // which attempts to check "file writing", as opposed to directory permissions + // (directory permissions can be broken, as per https://github.com/zealdocs/zeal/issues/1036) + // - by passing a nonexistent file we should get more correct results: m_isStorageReadOnly = !QFileInfo(nonExistentFile).isWritable(); #ifdef Q_OS_WIN32