remove unsafe vulkan installation #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @theofficialgman - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
I'll take into account installing the drivers into another directory. This PR removes the process of installing the latest Vulkan Mesa driver into your OS. I want to let users choose If they want to install it, even If It's not a secure option or you can break it. Come on, It's Linux! We deserve to break things IF WE WANT! So I'll reject this PR. Thank you anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #210
closes #209
📑 Description
Removes unsafe vulkan installation that overwrites system packages and breaks users installs.
ℹ Additional Information
If the developer wishes to re-add these in a safe manner here is what needs to be done:
/usr/local). All files can be installed there and are preferred over the main location (eg:/usr/local/bin/usr/local/share/usr/local/vulkan/, etc). Refer to the loader documentation for further explanation https://vulkan.lunarg.com/doc/view/1.3.275.0/linux/loader_and_layer_interface.htmlThe developer should add their own cleanup script to fix broken user installs caused by their previous script mistakes. The developer should send a notification to all users (via whatever method available to them) for the affected users. These are not covered in the context of this PR.