Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move flix-tech/avro-serde-php to optional libraries #21

Closed
Steveb-p opened this issue Jun 24, 2020 · 1 comment · Fixed by #22
Closed

Move flix-tech/avro-serde-php to optional libraries #21

Steveb-p opened this issue Jun 24, 2020 · 1 comment · Fixed by #22
Milestone
v1.0.0

Comments

@Steveb-p
Copy link

Currently flix-tech/avro-serde-php is a hard library requirement.
Instead it should be part of suggestions (https://getcomposer.org/doc/04-schema.md#suggest).

Classes that use it may throw descriptive errors if user attempts to use them without it.
@nick-zh nick-zh added this to the v1.0.0 milestone Jun 24, 2020
@nick-zh
Copy link
Contributor

nick-zh commented Jun 24, 2020

Great report, thx @Steveb-p

@nick-zh nick-zh linked a pull request Jun 29, 2020 that will close this issue
move avro serde to suggest, add installation hint #22
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

move avro serde to suggest, add installation hint jobcloud/php-kafka-lib
2 participants
@Steveb-p @nick-zh