Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over payload decode #7

Closed
nick-zh opened this issue Apr 19, 2020 · 0 comments · Fixed by #17
Closed

Control over payload decode #7

nick-zh opened this issue Apr 19, 2020 · 0 comments · Fixed by #17
Labels
consumer enhancement New feature or request
Milestone

Comments

@nick-zh
Copy link
Contributor

nick-zh commented Apr 19, 2020

For the next major we should change the current decoding logic.
Right now the message is immediately decoded, this should be an additional seperate step, triggered by the application.
The reason of Kafka headers is, that you can make quick decisions without decoding the payload.
With the current version of this lib, we always decode the payload and don't leverage that advantage.
Although the price for decode is small, this is of significance for topics with millions of messages.

@nick-zh nick-zh added this to the v1.0.0 milestone Apr 19, 2020
@nick-zh nick-zh added enhancement New feature or request consumer producer and removed producer labels Apr 19, 2020
@nick-zh nick-zh linked a pull request Apr 23, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant