add support for array creation #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Negative numbers need to be considered |
|
Hi @zeidoo thanks for the PR and sorry for the late response. I refactored this library and will be doing a major release shortly, but I'm going to merge this anyway to acknowledge the time and effort you took to contribute. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation always creates objects.
Added support for array creation for paths like a.0.
Example: set({}, 'a.0', 42)
Previous implementation would make "a" an Object with a property named "0" set to the number 42.
New implementation makes "a" and Array with the first element set to the number 42.
Should fix: #19