From bbd39c359f8a645687a001cf96f9d606240855b5 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sun, 21 May 2017 14:36:12 -0700
Subject: [PATCH] test: check noop function invocations

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: https://github.com/nodejs/node/pull/13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
---
 test/pummel/test-stream2-basic.js | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/test/pummel/test-stream2-basic.js b/test/pummel/test-stream2-basic.js
index 717c11b07e4abb..8a1d940ce77211 100644
--- a/test/pummel/test-stream2-basic.js
+++ b/test/pummel/test-stream2-basic.js
@@ -147,7 +147,7 @@ test('a most basic test', function(t) {
                    'xxxxxxxxxxxxxxxxxxxxx' ];
 
   r.on('end', function() {
-    t.same(reads, expect);
+    assert.strict(reads, expect);
     t.end();
   });
 
@@ -180,7 +180,7 @@ test('pipe', function(t) {
   const w = new TestWriter();
 
   w.on('end', function(received) {
-    t.same(received, expect);
+    assert.strict(received, expect);
     t.end();
   });
 
@@ -226,7 +226,7 @@ test('pipe', function(t) {
       t.equal(ended0, false);
       ended0 = true;
       ended++;
-      t.same(results, expect[0]);
+      assert.strict(results, expect[0]);
     });
 
     w[1].on('end', function(results) {
@@ -234,7 +234,7 @@ test('pipe', function(t) {
       ended1 = true;
       ended++;
       t.equal(ended, 2);
-      t.same(results, expect[1]);
+      assert.strict(results, expect[1]);
       t.end();
     });
 
@@ -261,11 +261,11 @@ test('multipipe', function(t) {
 
   let c = 2;
   w[0].on('end', function(received) {
-    t.same(received, expect, 'first');
+    assert.strict(received, expect, 'first');
     if (--c === 0) t.end();
   });
   w[1].on('end', function(received) {
-    t.same(received, expect, 'second');
+    assert.strict(received, expect, 'second');
     if (--c === 0) t.end();
   });
 
@@ -306,13 +306,13 @@ test('multipipe', function(t) {
 
     w[0].on('end', function(results) {
       ended++;
-      t.same(results, expect[0]);
+      assert.strict(results, expect[0]);
     });
 
     w[1].on('end', function(results) {
       ended++;
       t.equal(ended, 2);
-      t.same(results, expect[1]);
+      assert.strict(results, expect[1]);
       t.end();
     });
 
@@ -323,7 +323,7 @@ test('multipipe', function(t) {
 
 test('back pressure respected', function(t) {
   const r = new R({ objectMode: true });
-  r._read = common.noop;
+  r._read = common.mustNotCall();
   let counter = 0;
   r.push(['one']);
   r.push(['two']);
@@ -341,7 +341,7 @@ test('back pressure respected', function(t) {
       r.pipe(w3);
     });
   };
-  w1.end = common.noop;
+  w1.end = common.mustNotCall();
 
   r.pipe(w1);
 
@@ -367,7 +367,7 @@ test('back pressure respected', function(t) {
 
     return false;
   };
-  w2.end = common.noop;
+  w2.end = common.mustCall();
 
   const w3 = new R();
   w3.write = function(chunk) {
@@ -400,7 +400,7 @@ test('read(0) for ended streams', function(t) {
   const r = new R();
   let written = false;
   let ended = false;
-  r._read = common.noop;
+  r._read = common.mustNotCall();
 
   r.push(Buffer.from('foo'));
   r.push(null);
@@ -471,7 +471,7 @@ test('adding readable triggers data flow', function(t) {
 
 test('chainable', function(t) {
   const r = new R();
-  r._read = common.noop;
+  r._read = common.mustCall();
   const r2 = r.setEncoding('utf8').pause().resume().pause();
   t.equal(r, r2);
   t.end();