Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] overuse of console.warn? #31727

Closed
PhilETaylor opened this issue Dec 18, 2020 · 2 comments
Closed

[3.9] overuse of console.warn? #31727

PhilETaylor opened this issue Dec 18, 2020 · 2 comments

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented Dec 18, 2020

Steps to reproduce the issue

Without trying to invoke the JS gods on this...

while useful in development (in uncompressed js files) the console.warn messages are also showing up on live sites... do we really want to be doing that? its bad practice to output to the console log in production right?

These messages are actually only trigged just before a page "unloads" when a user clicks a button so are rarely seen anyway, unless the log is preserved between navigations

Expected result

Silence. Nothing logged on a live site using the compressed js files.

Actual result

Screenshot 2020-12-18 at 22 00 36

Screenshot 2020-12-18 at 22 03 33

System information (as much as possible)

Additional comments

@Fedik
Copy link
Member

Fedik commented Dec 19, 2020

Here you asked to much 😉

Well, all j3 js minified manually, by people who doing PR, here is no any fancy build tool that may allow to do it.
Just forget it

@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants