string.truncate fails to match closing tags with numerals #6149
Comments
|
Text fixed on gitHub, but that's not reflected here. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6149. |
|
Confirmed. To reproduce the problem I created a new menu entry to show a list of my archived articles and configured it to show the intro text with a limit of 20 chars. This of course assumes that archived articles are available having an intro text containing the sample text mentioned above. I think when searching for patterns like @MarkRS-UK, you should open a pull request for this issue. |
you need to use: http://issues.joomla.org/tracker/joomla-cms/6149/edit else the tracker will sync back the changes 😄 As you have code you can easy submit a pull request. If you don't know how see here: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6149. |
String truncate doesn't correctly match closing html tags that contain numbers. This change corrects this. Fixes joomla#6149
|
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/6149 |
|
Closing as we have a pull request here: http://issues.joomla.org/tracker/joomla-cms/6394 Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6149. |
Truncated text from articles containing an html element with numerals (currently only "h"(eader) exists) and another html element whose closing tag is removed in the truncation, will produce invalid html.
This is because the regex in string.truncate fails to match closing tags with numerals.
Steps to reproduce the issue
Put text like
<h1>Title</h1><p>Enough text to get truncated</p>at the beginning of an article that is then displayed with string.truncate.Expected result
The html
<h1>Title</h1><p>Partial text</p>...is producedActual result
The html
<h1>Title</h1><p>Partial text</p></h1>...is produced.This is invalid in that it produces a second, unmatched, closing h1 tag.
System information (as much as possible)
The incorrect code is in line 100 in /libraries/cms/html/string.php.
The match string is
#</([a-z]+)>#iUwhen it should be#</([a-z][a-z0-9]*)>#iUto match closing tags with numerals.
This renders correct html in the above example.
If we wanted to cover the case where a closing tag like
</h1 >was being matched, the pattern should be#</([a-z][a-z0-9]*)\b(?:[^>]*?)>#iUAdditional comments
This error, of course, afflicts truncateComplex too, since it calls truncate.
This code is called anywhere where a short extract from html is displayed, six different views in core components (content, tags, finder, newsfeed).
The text was updated successfully, but these errors were encountered: