Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifespan execution order #107

Closed
jordaneremieff opened this issue May 13, 2020 · 0 comments
Closed

Fix lifespan execution order #107

jordaneremieff opened this issue May 13, 2020 · 0 comments

Comments

@jordaneremieff
Copy link
Owner

While working on the example app I've run into an issue when interacting with the database in post requests. The initial request seems to work fine (db on startup/on close execute properly in lifespan context), but if I make a post request using a form (e.g. a login) the connection pool isn't acquired. I think this is because the lifespan startup should be run not in the adapter constructor, but rather in the event handler - this seemed to work and makes sense.

I'll make a PR for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant