Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdnjs still stuck on 2.7.1 #271

Closed
ghost opened this issue Dec 10, 2014 · 11 comments
Closed

cdnjs still stuck on 2.7.1 #271

ghost opened this issue Dec 10, 2014 · 11 comments

Comments

@ghost
Copy link

ghost commented Dec 10, 2014

I think it might be to do with the changearound on your github repo, but https://cdnjs.com/libraries/jplayer is still stuck on jplayer 2.7.1 and I guess quite a few of us rely on that.

Would be great to get it back in sync again - thanks!

@thepag
Copy link
Contributor

thepag commented Dec 12, 2014

Thanks for the heads up. I'll try and ping cdnjs early next week and make arrangements.
Otherwise, poke me!

@thepag
Copy link
Contributor

thepag commented Dec 14, 2014

I have been taking a look into this... And I can see why they removed the auto update from jPlayer... The skins not being in the dist folder would mean they have the /dist/ folder in the url too, after the version.

But... maybe I can jump above the base path and into skins for those. I will have to check with the cdnjs project and see what they recommend.

@ghost
Copy link
Author

ghost commented Dec 14, 2014

👍

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

Pull request issued:
cdnjs/cdnjs/pull/4103

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

In case you missed it, I moved the skins to use a SASS build system #260. In the future we can begin adding more variables to enable the changing of colours, widths and other stuff. I expect a new skin will be required to completely enable SASS control of the display.

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

It looks like the cdn is now up to date with 2.9.2 and I see some other versions being filled in too. I'll review in more detail this afternoon.

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

I'll also add in cdnjs as our official cdn on the download pages.

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

I've added the link to cdnjs on the download page.

I also setup gitter and added a link to it from the support page.

@thepag
Copy link
Contributor

thepag commented Dec 15, 2014

If you want to see the HTML for the skins in the CDN, then visit cdnjs/cdnjs/issues/3317 and 👍 it.

@PeterDaveHello
Copy link

It's 2.9.2 here https://cdnjs.com/libraries/jplayer

@thepag
Copy link
Contributor

thepag commented Dec 17, 2014

Closing this thread. The cdn is working fine again for the JS, CSS and images.

We will have to wait till the mustache HTML pages are supported on the CDN, and even then with sensible CORS in order for any HTML hosted there to be of any use.

@thepag thepag closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants