Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN Check Failure for Upcoming broom Release #27

Closed
simonpcouch opened this issue May 27, 2020 · 0 comments
Closed

CRAN Check Failure for Upcoming broom Release #27

simonpcouch opened this issue May 27, 2020 · 0 comments

Comments

@simonpcouch
Copy link
Contributor

Hi there! The broom dev team just ran reverse dependency checks on the upcoming broom 0.7.0 release and found new errors/test failures for the CRAN version of this package. I've pasted the results below, which seem to result from our planned deprecation of tidiers for mixed models.

  • checking examples ... ERROR

    ...
    To sustain an inference, 17334 of the cases with 0 effect would have to be replaced with cases at the threshold of inference.
    See Frank et al. (2013) for a description of the method
    [4mCitation:[24m Frank, K.A., Maroulis, S., Duong, M., and Kelcey, B. 2013. What would it take to change an inference? Using Rubin's causal model to interpret the robustness of causal inferences. [3mEducation, Evaluation and Policy Analysis, 35[23m 437-460.
    [1mImpact Threshold for a Confounding Variable:
    [22mThe minimum impact to invalidate an inference for a null hypothesis of 0 effect is based on a correlation of 5.535 with the outcome and at 5.535 with the predictor of interest (conditioning on observed covariates) based on a threshold of 1.003 for statistical significance (alpha = 0.05).
    Correspondingly the impact of an omitted variable (as defined in Frank 2000) must be 5.535 X 5.535 = 30.636 to invalidate an inference for a null hypothesis of 0 effect.
    See Frank (2000) for a description of the method
    [4mCitation:[24m Frank, K. 2000. Impact of a confounding variable on the inference of a regression coefficient. [3mSociological Methods and Research, 29[23m (2), 147-194
    NULL
    > 
    > # using lme4 for mixed effects (or multi-level) models
    > if (requireNamespace("lme4")) {
    +   library(lme4)
    +   m3 <- fm1 <- lme4::lmer(Reaction ~ Days + (1 | Subject), sleepstudy)
    +   konfound(m3, Days)
    + }
    Loading required namespace: lme4
    Warning: package ‘lme4’ was built under R version 3.6.2
    Loading required package: Matrix
    Error: No tidy method for objects of class lmerMod
    Execution halted
    
  • checking tests ...

     ERROR
    Running the tests in ‘tests/testthat.R’ failed.
    Last 13 lines of output:
      
      [31m──[39m [31m2. Error: (unknown) (@test-pkonfound.R#11) [39m [31m─────────────────────────────────[39m
      No tidy method for objects of class lmerMod
      [1mBacktrace:[22m
      [90m 1. [39mkonfound::konfound(testmod2, texp, test_all = TRUE, to_return = "raw_output")
      [90m 2. [39mkonfound:::konfound_lmer(...)
      [90m 4. [39mbroom:::tidy.default(model_object)
      
      ══ testthat results  ═══════════════════════════════════════════════════════════
      [ OK: 0 | SKIPPED: 0 | WARNINGS: 4 | FAILED: 2 ]
      1. Error: (unknown) (@test-mkonfound.r#12) 
      2. Error: (unknown) (@test-pkonfound.R#11) 
      
      Error: testthat unit tests failed
      Execution halted
    

Functions and methods for mixed models now live in the broom.mixed package.

We hope to submit this new version of the package to CRAN in the coming weeks. If you encounter any problems fixing these issues, please feel free to reach out!🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant