Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show config in adapter usage #71

Closed
jthegedus opened this issue May 14, 2021 · 1 comment · Fixed by #73
Closed

Show config in adapter usage #71

jthegedus opened this issue May 14, 2021 · 1 comment · Fixed by #73
Labels
documentation Improvements or additions to documentation enhancement New feature or request released

Comments

@jthegedus
Copy link
Owner

jthegedus commented May 14, 2021

Is your feature request related to a problem? Please describe.

The docs should also show usage of adapter options alongside zero-option usage it now shows.

Describe the solution you'd like

+import firebase from "svelte-adapter-firebase";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		// hydrate the <div id="svelte"> element in src/app.html
+       adapter: firebase(),
		target: '#svelte'
	}
};

export default config;

With options:

+import firebase from "svelte-adapter-firebase";

/** @type {import('@sveltejs/kit').Config} */
const config = {
	kit: {
		// hydrate the <div id="svelte"> element in src/app.html
-       adapter: firebase(),
+       adapter: firebase({ firebaseJson: '../firebase.json' }),
		target: '#svelte'
	}
};

export default config;

Describe alternatives you've considered

Additional context

@jthegedus jthegedus added documentation Improvements or additions to documentation enhancement New feature or request labels May 14, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 0.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant