From e3d48e3429db01f0b81cefbae25eb46744cd6e1a Mon Sep 17 00:00:00 2001 From: Marta Bondyra <4283304+mbondyra@users.noreply.github.com> Date: Wed, 11 Sep 2024 07:34:12 +0200 Subject: [PATCH] [Inline editor] correct the icon alignment, tooltip design and font size for the button (#192457) ## Summary Aligns the technical preview badge with the Create visualization title and reduce the Edit in Lens link text size to xs. (extracted from https://github.com/elastic/kibana/issues/192073) Before: Screenshot 2024-09-10 at 12 52 16 Screenshot 2024-09-10 at 13 09 25 After: Screenshot 2024-09-10 at 12 59 33 Screenshot 2024-09-10 at 13 09 14 --- .../shared/edit_on_the_fly/flyout_wrapper.tsx | 73 +++++++++++-------- .../translations/translations/fr-FR.json | 3 +- .../translations/translations/ja-JP.json | 3 +- .../translations/translations/zh-CN.json | 3 +- 4 files changed, 47 insertions(+), 35 deletions(-) diff --git a/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/flyout_wrapper.tsx b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/flyout_wrapper.tsx index 3c013cdc95998f..2e8ff8390673ff 100644 --- a/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/flyout_wrapper.tsx +++ b/x-pack/plugins/lens/public/app_plugin/shared/edit_on_the_fly/flyout_wrapper.tsx @@ -18,6 +18,7 @@ import { EuiButton, EuiLink, EuiBetaBadge, + EuiText, } from '@elastic/eui'; import { euiThemeVars } from '@kbn/ui-theme'; import { css } from '@emotion/react'; @@ -52,40 +53,54 @@ export const FlyoutWrapper = ({

- {isNewPanel - ? i18n.translate('xpack.lens.config.createVisualizationLabel', { - defaultMessage: 'Create {lang} visualization', - values: { lang: language }, - }) - : i18n.translate('xpack.lens.config.editVisualizationLabel', { - defaultMessage: 'Edit {lang} visualization', - values: { lang: language }, - })} - - - + + + {isNewPanel + ? i18n.translate('xpack.lens.config.createVisualizationLabel', { + defaultMessage: 'Create {lang} visualization', + values: { lang: language }, + }) + : i18n.translate('xpack.lens.config.editVisualizationLabel', { + defaultMessage: 'Edit {lang} visualization', + values: { lang: language }, + })} + + + + + + +

{navigateToLensEditor && ( - - {i18n.translate('xpack.lens.config.editLinkLabel', { - defaultMessage: 'Edit in Lens', - })} - + + + {i18n.translate('xpack.lens.config.editLinkLabel', { + defaultMessage: 'Edit in Lens', + })} + + )} diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index 94c3218ae520be..1a11dc831b6659 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -25100,7 +25100,6 @@ "xpack.lens.config.editLabel": "Modifier la configuration", "xpack.lens.config.editLinkLabel": "Modifier dans Lens", "xpack.lens.config.editVisualizationLabel": "Modifier la visualisation {lang}", - "xpack.lens.config.experimentalLabelDataview": "Version d'évaluation technique, l'édition en ligne propose actuellement des options de configuration limitées", "xpack.lens.config.visualizationConfigurationLabel": "Configuration de la visualisation", "xpack.lens.configPanel.addLayerButton": "Ajouter un calque", "xpack.lens.configPanel.loadFromLibrary": "Charger depuis la bibliothèque", @@ -47949,4 +47948,4 @@ "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "Ce champ est requis.", "xpack.watcher.watcherDescription": "Détectez les modifications survenant dans vos données en créant, gérant et monitorant des alertes." } -} +} \ No newline at end of file diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index 45c1da388c176c..8b9ea39876c836 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -25089,7 +25089,6 @@ "xpack.lens.config.editLabel": "構成の編集", "xpack.lens.config.editLinkLabel": "Lensで編集", "xpack.lens.config.editVisualizationLabel": "{lang}ビジュアライゼーションを編集", - "xpack.lens.config.experimentalLabelDataview": "テクニカルプレビュー。現在、インライン編集では、構成オプションは限られています。", "xpack.lens.config.visualizationConfigurationLabel": "ビジュアライゼーション構成", "xpack.lens.configPanel.addLayerButton": "レイヤーを追加", "xpack.lens.configPanel.loadFromLibrary": "ライブラリから読み込み", @@ -47932,4 +47931,4 @@ "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。", "xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。" } -} +} \ No newline at end of file diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index 55aa6ce129ae8b..7186bd6c5b6d94 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -25120,7 +25120,6 @@ "xpack.lens.config.editLabel": "编辑配置", "xpack.lens.config.editLinkLabel": "在 Lens 中编辑", "xpack.lens.config.editVisualizationLabel": "编辑 {lang} 可视化", - "xpack.lens.config.experimentalLabelDataview": "技术预览，内联编辑当前提供的配置选项数量有限", "xpack.lens.config.visualizationConfigurationLabel": "可视化配置", "xpack.lens.configPanel.addLayerButton": "添加图层", "xpack.lens.configPanel.loadFromLibrary": "从库中加载", @@ -47983,4 +47982,4 @@ "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。", "xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。" } -} +} \ No newline at end of file