-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing health check endpoint #124
Comments
PR sounds great! What should a health check look like? I would put it at |
@minrk It has to be exposed on the proxy itself (proxy-public port), because some limitations of GCE Ingress. I would go with |
If it has to be on the public port, I think it has to be something highly unlikely for any proxied application to serve, such as |
I think |
I'm a fan of the leading |
I think we won't be able to agree on this detail, so let's make it configurable. 🙂 |
Naming is hard 🤷♀️ Why don't we start with |
That does make it tempting to align with if it makes deployment easier. It does look like the value used for probes is configurable. |
That sounds great! I still would prefer a CHP prefix, though, so maybe
If it's common, then it's likely to also be exposed by something behind CHP. For instance, if JupyterHub implemented this standard endpoint and deployed with CHP in a single container (the default behavior), this should be proxied to the Hub and not served by CHP itself. Since CHP is a proxy, we have a special case because all URLs are in a shared namespace with proxied applications, so anything CHP-specific should be on a CHP-specific URL. Let's go with non-configurable |
Can't we have the health check only on the api port and not the proxy port? I'd much prefer that than overloading the proxying port :) This is what traefik does for example. |
@yuvipanda if that's possible, let's definitely do that. I thought @tothandras said this wasn't possible, though. |
Ah I see. I don't think kubernetes has that limitation - it's possible that GCE has it for their ingress, however. |
The proxy doesn't have a health check endpoint, which is very handy in a Kubernetes environment for readiness and liveness probes.
(I'm happy to contribute with a PR, when the details are discussed.)
The text was updated successfully, but these errors were encountered: