Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification to Autoscaling Docs RE: multiple node pools #1229

Closed
sgibson91 opened this issue Apr 11, 2019 · 5 comments
Closed

Clarification to Autoscaling Docs RE: multiple node pools #1229

sgibson91 opened this issue Apr 11, 2019 · 5 comments

Comments

@sgibson91
Copy link
Member

Hello!

These docs on auto-scaling should clarify that the labelling method described for efficiently scaling down is only useful if the Cloud provider supports multiple node pools with different labels in a single Kubernetes cluster. For instance, multiple node pools are not presently supported by Azure (though see Azure/AKS#287) so Azure users would need to be mindful that their cluster is scaling down efficiently.

@consideRatio
Copy link
Member

@sgibson91 it seems like AKS now supports multiple node pools as of november 2019 - Azure/AKS#287 (comment). I'll go ahead and close this.

@sgibson91
Copy link
Member Author

sgibson91 commented Oct 7, 2020

Yes, I can bring these docs across here if you like? https://alan-turing-institute.github.io/hub23-deploy/deploy-k8s-cluster-multiple-nodepools/

Also a new flag --labels is in preview for applying labels to new nodes within a pool when they automatically scale (up to now, they had to be manually applied) https://docs.microsoft.com/en-us/cli/azure/ext/aks-preview/aks/nodepool?view=azure-cli-latest#ext_aks_preview_az_aks_nodepool_add

@consideRatio consideRatio reopened this Oct 7, 2020
@consideRatio
Copy link
Member

;D wow what a resource! Well if updating this documentation, that resource could be referenced perhaps? Awesome documentation btw, I really appreciate it is public ❤️

@sgibson91
Copy link
Member Author

Closed by #1850

@consideRatio
Copy link
Member

Another closed issue!!!! Wieeee!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants