Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using existing imagePullSecrets #1344

Closed
sbrunk opened this issue Aug 1, 2019 · 2 comments
Closed

Allow using existing imagePullSecrets #1344

sbrunk opened this issue Aug 1, 2019 · 2 comments

Comments

@sbrunk
Copy link

sbrunk commented Aug 1, 2019

Right now it's possible to specify credentials for a private docker registry via hub.imagePullSecret and singleuser.imagePullSecret. This will create a new Secret from the given credentials and use it for pulling images.

In our setup we already have an existing Secret in our cluster we'd like to use as imagePullSecret. I'd be happy to create a PR adding this but I'd like to discuss how this could be configured first.

Here's the current block in values.yaml for specifying an pull secret (one for the hub and one for singleuser).

  imagePullSecret:
    enabled: false
    registry:
    username:
    email:
    password:

I guess one way would be to add an existing field and then set the pull secrets accordingly if enabled is false and existing is set to some value. What do you think?

@LaurentGoderre
Copy link
Contributor

LaurentGoderre commented Oct 3, 2019

I opened #1426 for this because we need this too!

@minrk
Copy link
Member

minrk commented Oct 10, 2019

closed by #1426

@minrk minrk closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants