Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove separator lines #68

Closed
xeliba opened this issue Jul 7, 2021 · 3 comments
Closed

Option to remove separator lines #68

xeliba opened this issue Jul 7, 2021 · 3 comments

Comments

@xeliba
Copy link

xeliba commented Jul 7, 2021

Many thanks for this nice extension!

I have a request for an aesthetic improvement. Is there an easy way to remove those separator lines?
example png

In my use case, I only want to add the Logout button, and this does not need to be draggable, so that the separator lines just look somewhat disturbing.

@xeliba
Copy link
Author

xeliba commented Jul 7, 2021

I realized this is possible by adapting the CSS style file in packages/jupyterlab-topbar/style/index.css on line 17

@@ -14,7 +14,7 @@
   display: flex;
   flex-direction: column;
   justify-content: center;
-  border-left: calc(var(--jp-border-width) * 2) solid var(--jp-border-color0);
+  border-left: calc(var(--jp-border-width) * 2) solid var(--jp-layout-color1);
   padding-left: 5px !important;
   padding-right: 5px !important;
 }

But maybe it's worth putting this into an option?

@jtpio
Copy link
Member

jtpio commented Jul 19, 2021

Thanks @xeliba.

These delimiters were initially placed to hint users the items can be moved via drag and drop. Maybe we could indeed remove them, and use a grab mouse cursor instead.

@jtpio
Copy link
Member

jtpio commented Jul 25, 2023

Closing as fixed by #92, which dropped the separator lines:

image

@jtpio jtpio closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants