Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the default tours into multiple plugins #40

Closed
jtpio opened this issue Jul 23, 2021 · 1 comment · Fixed by #75
Closed

Split the default tours into multiple plugins #40

jtpio opened this issue Jul 23, 2021 · 1 comment · Fixed by #75
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jul 23, 2021

Is your feature request related to a problem? Please describe.

This was originally discussed in jupyterlite/jupyterlite#287 (comment).

Where RetroLab doesn't handle the default welcome tour, but the notebook tour works out of the box.

Describe the solution you'd like

Maybe this logic could be split so the tours are added in separate plugins?

export function addTours(
manager: ITourManager,
app: JupyterFrontEnd,
nbTracker?: INotebookTracker
): void {
const { commands, shell } = app;
addWelcomeTour(manager, commands);
addNotebookTour(manager, commands, shell as ILabShell, nbTracker);
}

Or switch to using the settings-based way for defining tours for the defaults as well?

Describe alternatives you've considered

The plugin adding defaults could be disabled, and tours recreated manually.

Additional context

  • Python package version: 3.1.2
  • Extension version: 3.1.2
  • Operating System and its version: Ubuntu 20.04
@fcollonval
Copy link
Member

Those tours are more complicated as they interact with the UI. They cannot move to the settings.

I am not sure splitting them in multiple plugins is a good path as (I hope) the number of default tours will increase.

What about having a setting that select which default tours will be activated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants