Loading of static assets for disabled extensions #16082
Replies: 5 comments 1 reply
-
Or did you? I would not recommend using the CLI for this because it is error-prone. In this instance jupyter-ai does not follow the established practice of prefixing plugin names with the extension name, so I think you may have not achieved the result you wanted. Instead, jupyter-ai (as of version 2.12) has three plugins named Instead I would suggest trying out the Plugin Manager: https://jupyterlab.readthedocs.io/en/latest/user/extensions.html#managing-plugins-with-plugin-manager
This number seems off. There are way more JS files loaded on page reload. Which 12/11 files do you refer to? How do you defined "static" files in this context? Most of the extensions are loaded dynamically so it would not make sense to look at static files really. |
Beta Was this translation helpful? Give feedback.
-
Hi @krassowski, could you kindly respond? |
Beta Was this translation helpful? Give feedback.
-
Hi @krassowski, could you please kindly respond? |
Beta Was this translation helpful? Give feedback.
-
These files appear are the code of the extension. By static asset I would understand things like CSS, which is not loaded for disabled extensions since #11962. As for not loading the source when disabling individual plugins - this may be possible but may require some changes in webpack bundling and other parts of the infrastructure.
Well, it depends on what you mean by "expected". Expected by the users? Expected as "this is what was the intent of the author of the code"? For the former I guess it is not what you expect. For the latter I can only guess.
I would say of of today a couple:
Is it ideal? Probably not. The question is how can you/@linkedin contribute to make it better. I would suggest to start by opening an issue with a feature request to prevent the code of disabled plugins from loading. I can then respond with more thoughts on what technical challenges would need to be addressed. |
Beta Was this translation helpful? Give feedback.
-
Thanks for your reply @krassowski. Based on your above suggestion, have raised this feature request: #16135 |
Beta Was this translation helpful? Give feedback.
-
Hello team,
As per our earlier discussion in this thread: #15945, I was trying to validate whether the static assets are getting loaded for disabled extensions in jupyterlab 4. So for that I performed the following steps:
Can you please help me in understanding this behaviour? If disabling the extensions is not reducing the number of static JS files, that is getting loaded on page-reload, then what benefit this disabling of extensions functionality is offering us?
Best,
Raghav Mittal
Beta Was this translation helpful? Give feedback.
All reactions