Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up after scope change #21

Open
1 of 5 tasks
juranki opened this issue Mar 13, 2022 · 0 comments
Open
1 of 5 tasks

Clean up after scope change #21

juranki opened this issue Mar 13, 2022 · 0 comments

Comments

@juranki
Copy link
Owner

juranki commented Mar 13, 2022

  • There is now only one adapter, so it should be called adapter here
  • There's no longer a separate construct for lambda handler, so artifactPath is not needed in RendererProps here
  • Only CDK v2 is supported and there's just one construct, should it be in @sveltekit-cdk/construct instead of @sveltekit-cdk/constructsv2? eh...
  • App.render() is now Server.respond(), so RendererProps doesn't fit any more -> ServerProps
  • SvelteDistribution -> SvelteKitSite
    • Svelte != SvelteKit
    • the construct is a composition of distribution, function and bucket, so distribution is a bad name for it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant