Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve styleUrls regex #140

Closed
ghost opened this issue Jun 23, 2017 · 1 comment
Closed

Improve styleUrls regex #140

ghost opened this issue Jun 23, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Jun 23, 2017 •
edited by ghost
Loading

Hello,

It's not a "big bug". But it took me one hour to understand why my styleUrls scss file was not inlined.

I had to change from

styleUrls : ['image-chooser.scss']
to
styleUrls: ['image-chooser.scss']

Yes, I just had to remove the space between 'styleUrls' and ':'

I changed the code in gulp/inline-resources.js function inlineStyle

change regex from : /styleUrls:\s*
to/styleUrls\s*:\s*

Anyway, thanks for your job, great generator
@jvandemo
Copy link
Owner

@ixoh — Fix has been added and released as v11.0.1. Thank you for reporting, much appreciated! 👍

@snyk-bot snyk-bot mentioned this issue Sep 13, 2021
Open
@ronnysuero ronnysuero mentioned this issue May 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jvandemo