Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Error notifier #197

Closed
jwu910 opened this issue Jul 3, 2018 · 3 comments
Closed

Feature: Error notifier #197

jwu910 opened this issue Jul 3, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jwu910
Copy link
Owner

jwu910 commented Jul 3, 2018

NEW:
CIO should have a notification bar or popup (can be discussed), that will display when we want to notify users about something.

We should introduce a new interface that can accept the notification as text. This would create a very fluid experience while using CIO. This interface could potentially handle errors and even loading text


We should gracefully handle errors and notifications. When CIO errors, we should print it to the screen via blessed object.

We can utilize the blessed dependency to render a small popup when there is an error w/o crashing CIO. This should allow the user to still make use of CIO even though they may have an error like being unable to fetch due to limited connectivity.

Example use-case:

  • User attempts to press [r] to refresh their branch list, but the git request is unable to complete.
  • CIO should print to screen a message stating that CIO was unable to processes the refresh at this time, and the user can continue to use CIO.

This error notifier should lay the foundation to refactor the error handling in CIO.

Edit: Add details
Edit2: Update scope

@jwu910 jwu910 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 3, 2018
@jwu910 jwu910 added this to the Release 1.0.0 milestone Jul 6, 2018
@jwu910 jwu910 removed this from the Release 1.0.0 milestone Jul 19, 2018
@stale
Copy link

stale bot commented Sep 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 17, 2018
@stale
Copy link

stale bot commented Oct 1, 2018

This issue has been automatically closed due to inactivity. If this issue has not been resolved, please reopen the issue. Thank you.

@stale stale bot closed this as completed Oct 1, 2018
@jwu910 jwu910 added Hacktoberfest and removed wontfix This will not be worked on labels Oct 1, 2018
@jwu910 jwu910 reopened this Oct 1, 2018
@jwu910 jwu910 removed Hacktoberfest help wanted Extra attention is needed labels Oct 5, 2018
@jwu910 jwu910 self-assigned this Oct 5, 2018
@jwu910
Copy link
Owner Author

jwu910 commented Oct 5, 2018

#280 Will use this issue to manage this. Notifier should handle all messages, not just errors.

@jwu910 jwu910 closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant