Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial load screen disappears after a brief display #257

Closed
jwu910 opened this issue Sep 18, 2018 · 8 comments
Closed

Initial load screen disappears after a brief display #257

jwu910 opened this issue Sep 18, 2018 · 8 comments
Labels
bug Something isn't working

Comments

@jwu910
Copy link
Owner

jwu910 commented Sep 18, 2018

Actual: When starting Check It Out in a large project, the initial loading text will display before promptly disappearing for the remainder of the load time.

Expected: The loading text should be displayed during the entire load process.


I think this has to do with the order of operations that take place during initial start up time. The loading text should persist until we successfully fetch and parse all of our information needed.

This is much easier tested on a large project.
https://github.com/liferay/liferay-portal
This is a large enough project with years of git refs.

Note: Please refer to Contributing guidelines before starting development. Thanks!

@jwu910 jwu910 added bug Something isn't working good first issue Good for newcomers labels Sep 18, 2018
@jwu910 jwu910 added Hacktoberfest first-timers-only Short and simple fixes I can walk a first-timer through. labels Oct 1, 2018
@jwu910 jwu910 added the pinned Pinned issue label Dec 11, 2018
@jwu910 jwu910 added the up-for-grabs Short and simple fixes I can walk a first-timer through. label Jan 7, 2019
@JayaKrishnaNamburu
Copy link
Contributor

Hi, I liked the concept behind this and the way it is working and I would like to contribute to this 😄 . But I have few doubts regarding how to set up and work in development mode. I installed and ran npm run watch but I am a little confused how the dev commands are tested, I am kind of new to this node environments.

@jwu910
Copy link
Owner Author

jwu910 commented Feb 12, 2019

Hi @JayaKrishnaNamburu , I'd be happy to try and help walk you through setting up.

Until I get a test suite set up, local development testing is pretty much all user acceptance testing through manual clicks.

In the project folder you can run npm link which will bind the check it out command cio and checkit to the build files for your local repo. Then when you run Check It Out, it will use the build files from your repo rather than your npm global node_modules directory.

I hope this helps, let me know if you have more questions

@JayaKrishnaNamburu
Copy link
Contributor

Hi @JayaKrishnaNamburu , I'd be happy to try and help walk you through setting up.

Until I get a test suite set up, local development testing is pretty much all user acceptance testing through manual clicks.

In the project folder you can run npm link which will bind the check it out command cio and checkit to the build files for your local repo. Then when you run Check It Out, it will use the build files from your repo rather than your npm global node_modules directory.

I hope this helps, let me know if you have more questions

Thank you @jwu910 will try the process that you suggested 😄

@JayaKrishnaNamburu
Copy link
Contributor

Hi, @jwu910 please review the changes. Please let me know if is miss out anything 😅 .

@jwu910
Copy link
Owner Author

jwu910 commented Feb 14, 2019

Merged, thanks @JayaKrishnaNamburu !

@JayaKrishnaNamburu
Copy link
Contributor

Hi, @jwu910 please let me know if I can help with any other things in the repo. I will be happy to do.

@jwu910 jwu910 added pending-release Reviewed and merged into development and removed first-timers-only Short and simple fixes I can walk a first-timer through. good first issue Good for newcomers pinned Pinned issue up-for-grabs Short and simple fixes I can walk a first-timer through. labels Feb 14, 2019
@jwu910
Copy link
Owner Author

jwu910 commented Feb 14, 2019

@JayaKrishnaNamburu You can keep an eye on the issues, or star/subscribe to the repo to keep up to date! Thanks again

@JayaKrishnaNamburu
Copy link
Contributor

@JayaKrishnaNamburu You can keep an eye on the issues, or star/subscribe to the repo to keep up to date! Thanks again

sure 👍

@jwu910 jwu910 closed this as completed in 89dad42 Feb 14, 2019
@jwu910 jwu910 removed the pending-release Reviewed and merged into development label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants