-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal name remains as "Check It Out" after application has closed #296
Comments
Does this issue occur every time? I could not reproduce the issue on Ubuntu 18.04. |
Hmm I'll have to get back on my other machine and test a little more. I noticed it the other week. I was also on my default gnome shell. Were you using a different shell like Fish or Zsh? |
I just tried it using bash and zsh on gnome terminal, urxvt and xterm, and could not reproduce the issue on any combination of those. |
Thanks for taking another look. I'll dig into it a little deeper if I get time tomorrow. I'll leave the issue open for now. |
@ahlaw I just attached a gif to the original issue post at the top. I was on Antergos running the window manager i3 before, which is probably why I never saw this. I never had menu bars so it never came up. But I'll ask around and see if anyone else can reproduce as well. |
@jwu910 I cannot repro on mac mojave with iterm or default terminal. |
On ubuntu 16.04 LTS and I can reproduce the issue. Upon exiting application the terminal title is still "Check It Out". |
Hmm. I think we can probably still just remove the title attribute from the application. It may be an issue with the Blessed library that we used to render the screen. After looking at some other similar tools, I don't think its common practice to rewrite the window title anyways. |
OS: Ubuntu 18.04
Remove screen title property from the interface
Edit: Add gif
The text was updated successfully, but these errors were encountered: