Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal name remains as "Check It Out" after application has closed #296

Closed
jwu910 opened this issue Jan 9, 2019 · 8 comments
Closed

Comments

@jwu910
Copy link
Owner

jwu910 commented Jan 9, 2019

OS: Ubuntu 18.04

Remove screen title property from the interface

cioerror

Edit: Add gif

@jwu910 jwu910 added good first issue Good for newcomers first-timers-only Short and simple fixes I can walk a first-timer through. up-for-grabs Short and simple fixes I can walk a first-timer through. labels Jan 9, 2019
@ahlaw
Copy link
Contributor

ahlaw commented Jan 14, 2019

Does this issue occur every time? I could not reproduce the issue on Ubuntu 18.04.

@jwu910
Copy link
Owner Author

jwu910 commented Jan 14, 2019

Hmm I'll have to get back on my other machine and test a little more. I noticed it the other week.

I was also on my default gnome shell. Were you using a different shell like Fish or Zsh?

@ahlaw
Copy link
Contributor

ahlaw commented Jan 14, 2019

I just tried it using bash and zsh on gnome terminal, urxvt and xterm, and could not reproduce the issue on any combination of those.

@jwu910
Copy link
Owner Author

jwu910 commented Jan 14, 2019

Thanks for taking another look. I'll dig into it a little deeper if I get time tomorrow. I'll leave the issue open for now.

@jwu910
Copy link
Owner Author

jwu910 commented Jan 14, 2019

@ahlaw I just attached a gif to the original issue post at the top.

I was on Antergos running the window manager i3 before, which is probably why I never saw this. I never had menu bars so it never came up. But I'll ask around and see if anyone else can reproduce as well.

@protoEvangelion
Copy link

@jwu910 I cannot repro on mac mojave with iterm or default terminal.

@jwu910 jwu910 added bug Something isn't working discuss Discussion labels Jan 14, 2019
@antoniorhee
Copy link

On ubuntu 16.04 LTS and I can reproduce the issue. Upon exiting application the terminal title is still "Check It Out".

@jwu910
Copy link
Owner Author

jwu910 commented Jan 14, 2019

Hmm. I think we can probably still just remove the title attribute from the application. It may be an issue with the Blessed library that we used to render the screen.

After looking at some other similar tools, I don't think its common practice to rewrite the window title anyways.

@jwu910 jwu910 added pending-release Reviewed and merged into development and removed bug Something isn't working discuss Discussion first-timers-only Short and simple fixes I can walk a first-timer through. good first issue Good for newcomers up-for-grabs Short and simple fixes I can walk a first-timer through. labels Jan 15, 2019
@jwu910 jwu910 closed this as completed in ea27958 Feb 11, 2019
@jwu910 jwu910 removed the pending-release Reviewed and merged into development label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants